do not surround first key with brackets#16
Open
PavloBilyak wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It seems that due to an oversight in the
try_apiform key builder, the first argument is always wrapped in brackets, souser[id]becomes[user][id]. This pull request removes the wrapping of the first key, restoring compatibility with newer Rails versions. This change should not affect previous versions, as the updated behavior was expected.Background
In a recent Rails version (somewhere between
7.1.4and7.1.4.2), the way form arguments are parsed was changed. Specifically, if the first part of a key is surrounded by brackets (e.g.,[user][id]or[user_id]), it will be parsed as-is instead of being lifted as before.For example, form data with a key named
[user][id]will be parsed as{"[user]": { "id": 1 }}instead of{"user": { "id": 1 }}.